Skip to content

ci: "update to nx 21" followup fixes #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2025
Merged

ci: "update to nx 21" followup fixes #2576

merged 3 commits into from
Jul 28, 2025

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jul 26, 2025 •
edited
Loading

Summary:

Two fixes:

  1. After chore: update to nx 21 #2560 , I forgot to update the CI step that reads the nx.json tag. Let's do that, and have it properly fail if it can't find the tag.
    2, Fix nx release publish is confused by react-native-macos's prepublish script. #2580 by calling yarn npm publish directly.
  2. Use console.table() to print the react native artifacts updated in a release. Why? Because it looks cool.

Test Plan:

CI should pass.
Seriously, this looks cool!

 NX   No files would be changed as a result of running versioning

✅ Updated React Native artifacts
┌─────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ (index) │ Values                                                                                                           │
├─────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0       │ 'packages/react-native/ReactAndroid/gradle.properties'                                                           │
│ 1       │ 'packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java' │
│ 2       │ 'packages/react-native/React/Base/RCTVersion.m'                                                                  │
│ 3       │ 'packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h'                                                │
│ 4       │ 'packages/react-native/Libraries/Core/ReactNativeVersion.js'                                                     │
└─────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

@Saadnajmi Saadnajmi requested a review from a team as a code owner July 26, 2025 00:26
@Saadnajmi Saadnajmi mentioned this pull request Jul 26, 2025
Merged
@Saadnajmi Saadnajmi changed the title ci: update "read publish tag" step ci: nx 21 followup fixes Jul 26, 2025
@Saadnajmi Saadnajmi changed the title ci: nx 21 followup fixes ci: "update to nx 21" followup fixes Jul 26, 2025
@Saadnajmi Saadnajmi merged commit 370a5e1 into microsoft:main Jul 28, 2025
23 checks passed
@Saadnajmi Saadnajmi deleted the tag branch July 28, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nx release publish is confused by react-native-macos's prepublish script.
2 participants
@Saadnajmi @tido64